Add warning when using a textual date field specifier with the COMPAT locale provider #112548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
>non-issue
:Core/Infra/Core
thecoop
changed the title
thecoop
added
the
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
💚 Backport successful
|
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Sep 10, 2024
… locale provider (elastic#112548) Some textual field specifiers change between COMPAT and CLDR, depending on locale
felixbarny
reviewed
Sep 11, 2024
|
|
||
| // check for all textual fields, and localized zone offset | ||
| private static final Predicate<String> CONTAINS_CHANGING_TEXT_SPECIFIERS = System.getProperty("java.locale.providers", "") | ||
| .contains("COMPAT") ? Pattern.compile("[EcGaO]|MMM|LLL|eee|ccc|QQQ|ZZZZ").asPredicate() : Predicates.never(); |
There was a problem hiding this comment.
There are plenty of integration ingest pipelines that instantiate date and date_index_name processors that match this regex.
Is there a way to mitigate the impact for them and reduce the noise from deprecation logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn users if they're using a textual specifier that might change with CLDR - we can't do a full deprecation cycle, but this will help